Skip to main content

Django: Unittest for HttpResponseRedirect method recipe

I like to invent bicycles in my code. They often come in handy and you basically do not rely on Django version... So upon updating your project's Django version in future times you will not have to refactor half of all the code. So...

How do you test http redirects? I usually restrict my time in thinking and write code like if redirect target is hardcoded. And it really is in most of the times. But imagine if you decide to redirect your view response in several places. Or imagine if you're not the only one who owns you'r project's code and there are many collaborators that can change things without warning... And you need to have a test for that view that will test redirects and complex code behavior.

I used to check redirects like so:
response = self.cliet.get('/myview')
self.assertEqual(response.status_code, 302)
# View redirected... All ok...
But  if you have some view that can redirect to things that you need to check. How would you test that?  E.g. your view:
import random

def myview(request):
    url_end = random.choice([1,2,3,4])
    url = '/someplace/' + str(url_end)
    return HttpResponseRedirect(url)
It can produce many urls and you basically can not predict which one it will produce this time. Maybe it's not the best example. However it's quite simple and understandable IMHO. You're view can redirect you to:
/someplace/1
/someplace/2
...
Imagine if your program results may depend on that and you must check if the page rendering is properly relayed on that URL that you're redirecting.

How would you check that without relying much into Django variables and producing hacks? Exactly! You name it... Regexp's:
class MyTestCase(TestCase)

    def setUp(self):
        # We are using only logged in client in this test
        self.client.login(username=username, password=password)

    def test_mytest(self):
        response = self.client.get(reverse('myview'))
        # Following redirect in tests
        new_url = self._retrieve_redirect_response_url(response)
        response = self.client.get(new_url)
        self.assertEqual(response.status_code, 200)
        # No errors appeared
 
    def _retrieve_redirect_response_url(self, response):
        """
        My handy helper:
        
        parses 302 response object.
        Returns redirect url, parsed by regex.
        """
        self.assertEqual(response.status_code, 302)
        new_url = re.search(
                            # Our REGEXP:
                            "(?P<url>https?://[^\s]+)", 
                            str(response)).group("url"
                            )
        return new_url
A lot of third party logic exists in this test. But it's partially a live tests snippet with names changed. So you may assume it should be like so and concentrate your thoughts on this approach in general, rather than possible inconsistencies.

Main deed does regexp: "(?P<url>https?://[^\s]+)". Other code is only possible solution to use it in a handy way...  

Anyway, now you can use this snippet in your code to check url that view redirected you to. Only concern that I have here that there are much simpler approaches. But this one is almost Django updates independent. It stringifies your response and parses for url there.

If you want to know about re.search more: http://docs.python.org/howto/regex.html
Writing tests in general: https://docs.djangoproject.com/en/dev/topics/testing/?from=olddocs
Hope this will help someone. Comment your ideas on this! Appreciate your every thought...

Comments

  1. Thanks for the redirect test idea. The regex isn't really necessary I think, you can get the URL using:

    redirect_url = dict(response.items())['Location']

    ReplyDelete
  2. For anyone coming here from searching, check out the assertRedirects() in TestCase: https://docs.djangoproject.com/en/1.6/topics/testing/tools/#django.test.SimpleTestCase.assertRedirects

    ReplyDelete

Post a Comment

Popular posts from this blog

Pretty git Log

SO you dislike git log output in console like me and do not use it... Because it looks like so: How about this one? It's quite easy... Just type: git log - - graph - - pretty = format : '%Cred%h%Creset -%C ( yellow ) %d%Creset %s %Cgreen ( %cr) %C ( bold blue ) <%an>%Creset' - - abbrev - commit - - It may be hard to enter such an easy command every time. Let's make an alias instead... Copypaste this to your terminal: git config --global alias.lg "log --color --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit --" And use simple command to see this pretty log instead: git lg Now in case you want to see lines that changed use: git lg - p In order for this command to work remove  the -- from the end of the alias. May the code be with you! NOTE: this article is a rewritten copy of  http://coderwall.com/p/euwpig?i=3&p=1&t=git   and have b...

Django: Resetting Passwords (with internal tools)

I have had a task recently. It was about adding a forms/mechanism for resetting a password in our Django based project. We have had our own registration system ongoing... It's a corporate sector project. So you can not go and register yourself. Admins (probably via LDAP sync) will register your email/login in system. So you have to go there and only set yourself a password. For security reasons you can not register. One word. First I've tried to find standart decision. From reviewed by me were: django-registration and django password-reset . These are nice tools to install and give it a go. But I've needed a more complex decision. And the idea was that own bicycle is always better. So I've thought of django admin and that it has all the things you need to do this yourself in no time. (Actually it's django.contrib.auth part of django, but used out of the box in Admin UI) You can find views you need for this in there. they are: password_reset password_reset_...

Vagrant error: * Unknown configuration section 'hostmanager'.

Sometimes you get a vagrant environment or boilerplate with a Vagrantfile config in there and do a vagrant up command. And see some errors. like this: There are errors in the configuration of this machine . Please fix the following errors and try again : Vagrant: * Unknown configuration section 'hostmanager'. To fix this one needs: $ vagrant plugin install vagrant - hostmanager Installing the ' vagrant-hostmanager ' plugin . This can take a few minutes . . . Fetching : vagrant - hostmanager - 1.8 .6 . gem ( 100 % ) Installed the plugin ' vagrant-hostmanager (1.8.6) ' ! So command to fix this as follows: vagrant plugin install vagrant-hostmanager